Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hippie-swagger depends on hippie being installed by parent #13

Closed
toshi38 opened this issue Sep 26, 2016 · 1 comment
Closed

hippie-swagger depends on hippie being installed by parent #13

toshi38 opened this issue Sep 26, 2016 · 1 comment

Comments

@toshi38
Copy link
Contributor

toshi38 commented Sep 26, 2016

Is there some reason that in order to use hippie swagger we need to install hippie separately?

ie I need to do both:

npm install hippie-swagger --save-dev
npm install hippie --save-dev

Why not just have it as a dependency?

Happy to fix it if someone agrees with me :)

@CacheControl
Copy link
Owner

@toshi38 Initially I was thinking of this project as a plugin for hippie, which is why it is listed as a peer dependency....however your issue has made me rethink that position. I think it's a safe bet that most people who use this project don't have an existing hippie install, and it's probably annoying that they need to run an extra command.

Since you offered, if you'd like to move hippie into the dependencies list, I'll happily merge it. I'll also probably release this as a major version, to prevent issues with anyone having to reconcile their existing version of hippie with whatever we peg as current.

thanks for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants