Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should log deletions through the Rest API #676

Open
drnlm opened this issue Sep 3, 2023 · 2 comments
Open

Should log deletions through the Rest API #676

drnlm opened this issue Sep 3, 2023 · 2 comments

Comments

@drnlm
Copy link
Member

drnlm commented Sep 3, 2023

We allow deletion via the REST APi - we should maybe change that to also just withdraw the talk (although the semantics are a bit awkward with the DELETE method), but,if we don't, we should log the action somewhere.

We use reversion to log other changes to the object via the API, but that doesn't handle deletions particularly nicely - maybe we should log it directly to the admin log?

Alternatively, adding something like drf-api-logger so we keep track of all API usage may be the way to go?

@hodgestar
Copy link
Member

I would be happy removing the DELETE method and perhaps adding a withdraw endpoint or easy support for updating the status of the talk.

drf-api-logger sounds quite cool too though. Is it something Wafer sites could enable purely in config if we did things nicely in the core?

@drnlm
Copy link
Member Author

drnlm commented Sep 3, 2023

I haven't had a chance to play with drf-api-logger yet, but in theory it should be simple to enable with little to no changes to wafer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants