Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Inconsistent Comment in cli.py #128

Open
djfinn14 opened this issue Jun 29, 2017 · 2 comments
Open

Inconsistent Comment in cli.py #128

djfinn14 opened this issue Jun 29, 2017 · 2 comments

Comments

@djfinn14
Copy link
Contributor

In the provision method of cli.py there is an inconsistency between the comments and the actual parameters of the method. In the comments there is a mention of a CHANNEL, but there is no CHANNEL parameter:

def provision(project, node, img, network, nic):
    """
    Provision a Node
    \b
    Arguments:
    PROJECT = The HIL Project attached to your credentials
    NODE    = The Node to Provision
    IMG     = The Name of the Image to Provision
    NETWORK = The Name of the Provisioning Network
    CHANNEL = The Channel to Provision On (For HIL It is 'vlan/native')
    NIC     = The NIC to use for Network Boot (For HIL IT is 'enp130s0f0')
    """
@djfinn14 djfinn14 changed the title Inconsistent Comments in cli.py Inconsistent Comment in cli.py Jun 29, 2017
@ravisantoshgudimetla
Copy link
Contributor

cli.py is something that was not reviewed at all. I recommend to get started on reviewing/rewriting it. IIRC, it had some direct DB calls.

/cc @chemistry-sourabh

@apoorvemohan
Copy link
Collaborator

@chemistry-sourabh @naved001 can we close this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants