Suggest --fixed-strings flag in case of regex parse error (closes #709) #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested changes
Jan 1, 2018
src/args.rs
Outdated
| GrepError::Regex(err) => { | ||
| let s = format!("{}\nIf you wanted to treat the \ | ||
| string within double quotes as a literal string, you \ | ||
| should pass the --fixed-strings flag.", err.to_string()); |
There was a problem hiding this comment.
I think I would just write, \n(Hint: try the --fixed-strings flag to search a literal.)
tests/tests.rs
Outdated
|
|
||
| let output = cmd.output().unwrap(); | ||
| let err = String::from_utf8_lossy(&output.stderr); | ||
| let expected = "If you wanted to treat the string within double quotes as a literal string, you should pass the --fixed-strings flag. |
There was a problem hiding this comment.
Please find a way to wrap this to 79 columns. :)
Also, I'd probably just check that the error message mentions --fixed-strings, otherwise the test will probably be unusefully brittle.
|
Done. And yeah, I kinda felt iffy about that test, thanks for suggesting a better one. :-) |
|
Just a heads up: I just noticed that the commit message for this merge says fixes 727 (the PR No), instead of 709. |
|
@balajisivaraman Whoops. I goofed in the commit message. Ah well. I ain't force pushing master, so we'll just have to live with it. :) Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most straightforward fix I could think of for #709. Please let me know if it could be improved upon.
Thanks!