Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd (.zst) to the --search-zip support (extension of #539) #1099

Closed
cemeyer opened this issue Nov 3, 2018 · 1 comment
Closed

Add zstd (.zst) to the --search-zip support (extension of #539) #1099

cemeyer opened this issue Nov 3, 2018 · 1 comment

Comments

@cemeyer
Copy link
Contributor

cemeyer commented Nov 3, 2018

What version of ripgrep are you using?

git master

Describe your question, feature request, or bug.

Just need an additional list entry in https://github.com/BurntSushi/ripgrep/blob/master/grep-cli/src/decompress.rs#L349 and a small update to the manual page. Kudos to @balajisivaraman for already having done the work to easily add more decompressors in a general fashion.

Something like:

+ const ARGS_ZSTD: &[&str] = &["zstd", "-d", "-c"];
...
+     cmd("*.zst", ARGS_ZSTD),

I can't find where the OPTIONS (-z, --search-zip) portion of the manual page is stored in the directory hierarchy, but that should be updated as well.

Should be pretty trivial! Thanks for considering it.

@cemeyer
Copy link
Contributor Author

cemeyer commented Jan 23, 2019

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant