-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
an invalid pattern in gitignore causes all other patterns to be ignored #87
Comments
I can't seem to reproduce the problem, could you please give a more detailed test case?
Note that I've fixed a few bugs with |
Also, please show the output of |
Replicating your example everything works but in my repo the result is different It's a big repo & the output with
But, I commend out my |
Is there any way for you to try current master? It would require installing Rust and compiling ripgrep (instructions in the README). If not, that's OK, but I'd suggest we stop debugging the issue until I get the next release out for you to try (which should be today). I say this because I've fixed a few bugs related to gitignore. |
Ok I'll wait for the new release then. Thanks anyway 👍 |
I just tagged a new release, |
Looks like they're up. The |
Here is another test after installing the latest version, same repo different string: $ brew rm ripgrep && brew install https://raw.githubusercontent.com/BurntSushi/ripgrep/master/pkg/brew/ripgrep.rb
$ rg -w -tjs "selectize" -c
app/admin/assets/javascripts/application.js:1
app/admin/assets/javascripts/lib/address.js:2
app/admin/assets/javascripts/view/selectize.js:13
app/admin/assets/javascripts/view/tables.js:1
app/services/assets/javascripts/fair.js:1
app/services/assets/javascripts/signup.js:1
app/services/assets/javascripts/input.js:1
node_modules/selectize/dist/js/selectize.js:22
node_modules/selectize/dist/js/standalone/selectize.js:23
node_modules/selectize/examples/js/index.js:1
node_modules/selectize/Gruntfile.js:27
node_modules/selectize/dist/js/selectize.min.js:3
node_modules/selectize/karma.conf.js:4
node_modules/selectize/src/.wrapper.js:1
node_modules/selectize/src/defaults.js:4
node_modules/selectize/src/plugins/drag_drop/plugin.js:1
node_modules/selectize/src/plugins/dropdown_header/plugin.js:5
node_modules/selectize/src/plugins/optgroup_columns/plugin.js:1
node_modules/selectize/src/plugins/remove_button/plugin.js:1
node_modules/selectize/src/plugins/restore_on_backspace/plugin.js:1
node_modules/selectize/src/selectize.jquery.js:7
node_modules/selectize/src/selectize.js:6
node_modules/selectize/test/events_dom.js:3
node_modules/selectize/dist/js/standalone/selectize.min.js:3
node_modules/selectize/test/events.js:57
node_modules/selectize/test/setup.js:37
node_modules/selectize/test/support/base.js:3
node_modules/selectize/test/interaction.js:73
node_modules/selectize/test/api.js:204
node_modules/selectize/test/xss.js:2
public/assets/services/fair.js:2
public/assets/services/signup.js:2
public/assets/admin/application.js:4
# with ag
$ ag --js "\bselectize\b" -l
app/admin/assets/javascripts/application.js
app/admin/assets/javascripts/lib/address.js
app/admin/assets/javascripts/view/selectize.js
app/admin/assets/javascripts/view/tables.js
app/services/assets/javascripts/fair.js
app/services/assets/javascripts/signup.js
app/services/assets/javascripts/input.js
Simply any file that matches |
I still can't reproduce this. I tried running Is there anyway for you to pair down your |
I found the problem! it's in our |
@ahmedelgabri Oh! That will do it. The actual problem is that
To clarify, the correct way to write that pattern is |
Thank you so much for looking into this! |
Yeah I'm working with person who added this & we are fixing this, thank you for the clarification! |
Here is a couple of ideas on how I'm thinking about dealing with this 1- ignore the faulty pattern & respect the rest (maybe show a warning message too) |
@ahmedelgabri (1) is absolutely the way to go. We should dump the error message from parsing the pattern to the debug output (which is only shown when I think this means that I'd be happy to mentor this change (even if you don't know Rust). Otherwise, I'm also happy to just fix it. :-) |
I have never written a single Rust line in my life, I don't mind trying But I'll need help starting from setting up my env to maybe even the smallest of stuff 😬 |
The Rust book should help get you started! |
Thanks! |
@ahmedelgabri Let me know if there's anything I can do to help. :-) |
I have this line in my project
.gitignore
but when I do search for a string it still returns results from these paths. Whileag
respect the ignored paths & doesn't show any results from there. Maybe I'm missing something here?Here the commands
The text was updated successfully, but these errors were encountered: