Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.0 always follows symlinks #824

Closed
chrmarti opened this issue Feb 19, 2018 · 3 comments
Closed

0.8.0 always follows symlinks #824

chrmarti opened this issue Feb 19, 2018 · 3 comments
Labels
bug A bug.

Comments

@chrmarti
Copy link
Contributor

What version of ripgrep are you using?

0.8.0

What operating system are you using ripgrep on?

Windows 10 64bit

If this is a bug, what are the steps to reproduce the behavior?

0.8.0 always follows symlinks, also without --follow:

  • create two sibling folders cwd and linktarget
  • create one file in each folder cwd\\one.txt and linktarget\\two.txt
  • create a link in the cwd folder targeting the linktarget folder:
    • mklink /d link ..\\linktarget
  • run ripgrep in cwd: rg --files

Also reproduces without --files.

If this is a bug, what is the actual behavior?

DEBUG/grep::search/grep\src\search.rs:195: regex ast:
Repeat {
    e: Literal {
        chars: [
            'z'
        ],
        casei: false
    },
    r: Range {
        min: 0,
        max: Some(
            0
        )
    },
    greedy: true
}
one.txt
link\two.txt

If this is a bug, what is the expected behavior?

one.txt

/cc @roblourens

@BurntSushi
Copy link
Owner

BurntSushi commented Feb 20, 2018

@chrmarti Thanks for the great bug report! This was fallout as a result of fixing #705. This should be fixed on master.

@BurntSushi BurntSushi added the bug A bug. label Feb 21, 2018
@BurntSushi
Copy link
Owner

BurntSushi commented Feb 21, 2018

@chrmarti @roblourens ripgrep 0.8.1 is out with this and #820 fixed.

@chrmarti
Copy link
Contributor Author

Great, thanks @BurntSushi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug.
Projects
None yet
Development

No branches or pull requests

2 participants