Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsis_id 200908090 showing plays where player is on both teams in play_player #60

Open
albertlyu opened this issue Sep 25, 2014 · 1 comment
Labels

Comments

@albertlyu
Copy link

I'm seeing something wrong with play_player records for a 2009 preseason game with gsis_id 200908090 where 17 players have records belonging to both teams (TEN and BUF). I found this error when I was grouping the play_player table by player_id, gsis_id, and team because I wanted to create a new table at the player, game level. See the SQL I wrote and the output below:

SELECT gsis_id, player_id 
FROM play_player 
WHERE gsis_id = '2009080950' 
GROUP BY gsis_id, player_id 
HAVING COUNT(DISTINCT team) > 1;
  gsis_id   | player_id  
------------+------------
 2009080950 | 00-0021379
 2009080950 | 00-0022100
 2009080950 | 00-0024690
 2009080950 | 00-0025437
 2009080950 | 00-0025515
 2009080950 | 00-0025585
 2009080950 | 00-0026225
 2009080950 | 00-0026243
 2009080950 | 00-0026266
 2009080950 | 00-0026274
 2009080950 | 00-0026550
 2009080950 | 00-0027038
 2009080950 | 00-0027061
 2009080950 | 00-0027066
 2009080950 | 00-0027095
 2009080950 | 00-0027120
 2009080950 | 00-0027136
(17 rows)

So if I'm understanding this right, all these 17 players have records of plays where they belonged to both TEN and BUF.

I believe my database is up-to-date -- is anyone else getting this same output? If so, I just wanted to make you aware of this somewhat minor data issue, which very well could have come from the pbp source. Curiously, this is the very first game in nfldb.

@BurntSushi BurntSushi added the bug label Dec 2, 2014
@BurntSushi
Copy link
Owner

Yup, I'm also getting this behavior. (Sorry for the late response.)

If it's a one time thing, then maybe I can patch the source JSON in nflgame. But I admit this will be low priority, particularly since it's a preseason game. I should check if there are other games that exhibit this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants