Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: animate does not work well with virtual tables (e.g. FixedDataTable) #586

Open
timhwang21 opened this issue Aug 22, 2016 · 0 comments

Comments

@timhwang21
Copy link

When animate={true} in a virtualized table (e.g. Facebook's FixedDataTable) and the table is rerendered for whatever reason (e.g. pagination, filtering), the switches show the toggling animation. This leads to a misleading UX, as no state is actually changing. This occurs because the switches are not actually being unmounted / re-mounted, and as such any switch whose state is changed will think that it is toggled.

I'm having trouble thinking about an elegant fix. Initially for my scenario, I added state to enable animation only when the switch is clicked, or when a 'toggle all' button is pressed. However I'm not sure how the component can distinguish whether its value is changing due to a 'toggle all' being pressed or if the virtual table data has changed.

Has anyone had a similar issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant