bug fix for #449 #589
Closed
bug fix for #449 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that if clicking an indeterminate element to false, the switchChange event was not fired as the options.state would be false.
…into stralytic-master
|
Thanks for the contribution. Should this PR prevail the other open one? In any case, have a look at this comment and remove conflicts by checking out latest |
|
@mzimmerman I'm doing some housekeeping after a long time. Are changes still relevant? |
|
I actually have no idea! I honestly don't even remember what I fixed or why! |
|
Inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates pull request #449 which fixes #541
This can be merged into master now with no conflicts. gulp seemed to test fine, however I admit I'm not a javascript / npm / gulp person so I'm not sure what I'd be looking for in terms of failure either.
Thanks to @stralytic