Ability to prevent switching inside event handler

[raveren]

I don't really need this at the moment, this is just for uniformity, other high quality jquery plugins usually implement some way to prevent user from performing actions in event callbacks:

$("[name='my-checkbox']").bootstrapSwitch({
  onSwitchChange: function(e) {
    if( iHaveAReason ) {
       e.preventDefault();
       // or - equivalently
       return false;
    }
  }
});

Returning false from event handler would also stop propagation, but in this case, when switches never contain other switches, that's irrelevant.

[daverogers]

+1. I was looking for this functionality so I can first display a confirmation to the user before unchecking a particular option that is very important.

[LostCrew]

@daverogers @raveren i opened a branch for it, but it will take some time since it requires many parts to be rewritten.

[mkrauser]

+1 from me. This would be a great improvement! Looking forward to this

[mgoldsborough]

+1. It would be a huge help. Like @daverogers, I need to a confirmation modal too.

[nbhuy89]

+1

[filipalacerda]

+1

[dflock]

+1

[DennisVM]

+1

[mmunchandersen]

+1

[nostalgiaz]

Can anyone give me feedback before merging this commit in master? 61b2289

[mgoldsborough]

Works for me! Thanks for the add.

For those looking for how to implement...

var options = {
  onSwitchChange: function(event, state) {
    // Return false to prevent the toggle from switching.
    return false;
  }
};

$('[name="my-checkbox"]').bootstrapSwitch(options);

Then when you want to programmatically toggle the switch:

$('[name="my-checkbox"]').bootstrapSwitch('toggleState', true);

The true flag will cause the library to skip the onSwitchChange event handler defined above.

Hope that helps.

[nostalgiaz]

Thanks @mgoldsborough for these lines of documentation ;) I need to talk with @LostCrew in order to decide when and how to release this feature.

[nostalgiaz]

With @LostCrew , we decided to refactor a little bit the code, anyway this will be released in the 3.3.3 version.

[fuvizzo]

@mgoldsborough I got the release 3.3.2.
I put return false; in the onSwitchChange but this does not prevent the switch to toggle.
Did I miss something?

[mgoldsborough]

@fuvizzo this functionality is not yet released.

@nostalgiaz @LostCrew, any updates on when v3.3.3 (or 3.4.0) will be tagged and released?

[nostalgiaz]

@mgoldsborough is it ready for production?

[Neelu-Chaturvedi]

Badly need this functionality. When would it be released

[mgoldsborough]

@nostalgiaz Yes, I think so? It's working for me. I'd reco a tag/release. Thanks.

[OakBehringer]

+1 need this released

[nostalgiaz]

@OakBehringer here we go... the code is in master.

[OakBehringer]

Awesome - thanks!

[OakBehringer]

I take it back.

bootstrap-switch.js and bootstrap-switch.min.js haven't been changed for 2 months. Same with the coffee scripts.

???

[santhosh-v]

+1

[davidworkman9]

+1

[shobeurself]

+1

[crowbarsolutions]

+1

[asane06]

+1

[badcom]

Hasn't this been implemented yet?

[ghost]

Bump

Has this been implemented yet? Sample code from @mgoldsborough over a year ago doesn't seem to work.

My problem is I have a read-only page with labels and the switch is disabled but users can click on the label to toggle the switch. Check this jsfiddle.

As a side note, if you add the disabled attribute to the checkbox then the functionality works as expected. To me it makes sense to add the disabled attribute to the elements based on the selector when the disabled option is set and remove it when disabled: false. This might be a nonissue, though. Anyone have thoughts on this?

Edit: Stupid me...pending label is set.

[badcom]

In my case I added a transparent DIV over the switch button, then I change the switch state on a click event. This disabled the slide functionality, but it solved my problem :)