Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Temporary Mode #15

Merged
merged 3 commits into from
Jun 26, 2024
Merged

feat: Add Temporary Mode #15

merged 3 commits into from
Jun 26, 2024

Conversation

srilman
Copy link
Contributor

@srilman srilman commented Jun 23, 2024

Closes #10. Temporary mode allows users to start up an ephemeral REST catalog for testing purposes with minimal pre-setup. It automatically:

  • Chooses a randomly available port (unless an explicit port is provided via the --port argument
  • Uses an in-memory SQLite server
  • Sets up a warehouse in a temporary local path

In addition, this PR contains:

  • Options to support random port finding for regular mode
  • Some go.mod cleanup

@srilman srilman requested a review from ritwika314 June 23, 2024 22:46
ritwika314
ritwika314 approved these changes Jun 24, 2024
View reviewed changes
Copy link

@ritwika314 ritwika314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but LGTM otherwise, thank you!

logic/state.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@srilman srilman merged commit 3bf3064 into main Jun 26, 2024
@srilman srilman deleted the slade/temp-mode branch June 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritwika314 ritwika314 ritwika314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Ephemeral / Temp Mode
2 participants
@srilman @ritwika314