Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify screen size unit #66

Open
ggael opened this issue Sep 20, 2022 · 1 comment
Open

Unify screen size unit #66

ggael opened this issue Sep 20, 2022 · 1 comment

Comments

@ggael
Copy link
Collaborator

ggael commented Sep 20, 2022

For Apple's smartphones and the likes, screen_size corresponds to the screen resolution in pixels, whereas for monitors and laptops it corresponds to inches.
@AirLoren
Copy link
Contributor

Last Apple reports don't mention screen size.
I suggest only collecting screen_size when available in PER/PCF in inches.
Do you have any other idea @ggael ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggael @AirLoren