Problem with repeat of payments

[filipfonal]

I have a problem with payments. If I've been redirect to PayU and left this page (for example closing browser tab) and then try repeat payment in user panel I get error 500 with this message:

ERROR_ORDER_NOT_UNIQUE - Order with given extOrderId already exists

Has anyone had this problem or knows how to fix it?

[wobokas]

I have exactly the same problem

[mikemix]

@bitbager ?

In the ConvertPaymentAction class, line 43:

$details['extOrderId'] = uniqid((string) $payment->getNumber(), true);

Should be unique instead, not deterministic as above:

$details['extOrderId'] = uniqid(md5(mt_rand(0, 1000000)), true);

Because PayU's order != Sylius payment id

To everybody, to fix this you have to decorate this service and remove this unnecessary extOrderId key:

<?php

declare(strict_types=1);

namespace App\Payment\PayU;

use BitBag\SyliusPayUPlugin\Action\ConvertPaymentAction;
use Payum\Core\Action\ActionInterface;
use Payum\Core\GatewayAwareInterface;
use Payum\Core\GatewayAwareTrait;
use Payum\Core\Request\Convert;

final class ConvertPaymentActionDecorator implements ActionInterface, GatewayAwareInterface
{
    use GatewayAwareTrait;

    private $action;

    public function __construct(ConvertPaymentAction $action)
    {
        $this->action = $action;
    }

    /**
     * @param Convert $request
     */
    public function execute($request): void
    {
        $this->action->execute($request);

        $details = $request->getResult();

        unset($details['extOrderId']);

        $request->setResult($details);
    }

    public function supports($request): bool
    {
        return $this->action->supports($request);
    }
}

and register this as a service to decorate the original action:

App\Payment\PayU\ConvertPaymentActionDecorator:
    decorates: bitbag.payu_plugin.action.convert_payment
    arguments: ['@App\Payment\PayU\ConvertPaymentActionDecorator.inner']