Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit imports, not using FASTX #17

Open
jakobnissen opened this issue Mar 6, 2023 · 0 comments
Open

Use explicit imports, not using FASTX #17

jakobnissen opened this issue Mar 6, 2023 · 0 comments

Comments

@jakobnissen
Copy link
Member

Writing using FASTX (or any other package) is bad for two reasons:

  • If FASTX in a new version exports a new name, it may conflict with an existing names in ReadDatastores, causing an error. This means that even adding new features to FASTX can break this package
  • It makes it harder to find the definition the used functions

All of these should be replaced with using FASTX: Foo, Bar, baz, or, if FASTX internals is used, using FASTX: FASTX, Foo, Bar, baz, such that e.g. FASTX.qux can be accessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant