Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If player changes biome and delete Island, biome queue is still processed #116

Open
Waterman1001 opened this issue Mar 12, 2023 · 2 comments
Labels
Status: Pending Waiting for a developer to start working on this issue. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@Waterman1001
Copy link

Expected behavior

I expected that the biome change would not happen anymore and that if a player deletes his island, the biome change a player requested would be removed from the queue of biome changes.

Observed/Actual behavior

I saw that the biome change actually happened after the player removed his island.

image

See the image. The player did not have an Island anymore. However, the queue was still being processed

Steps/models to reproduce

  1. Player changes biome.
  2. Biome change is added to queue and can take 150 seconds.
  3. Player removes island.
  4. Biome change still happens.

BentoBox version

[02:25:29 INFO]: Running PAPER 1.19.3.
[02:25:29 INFO]: BentoBox version: 1.22.0
[02:25:29 INFO]: Database: JSON
[02:25:29 INFO]: Loaded Game Worlds:
[02:25:29 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[02:25:29 INFO]: Loaded Addons:
[02:25:29 INFO]: Biomes 2.2.0-SNAPSHOT-b245 (ENABLED)
[02:25:29 INFO]: BSkyBlock 1.17.0-SNAPSHOT-b730 (ENABLED)

Plugin list

[02:25:52 INFO]: BentoBox, BlueSlimeCore, BroadcasterSVG, BuycraftX, ChatControl, Citizens, CombatLogX, CommandHook, CoreProtect, CoreSVG
[02:25:52 INFO]: CustomItemsLib, EchoPet, Essentials, EssentialsAntiBuild, EssentialsChat, EssentialsProtect, EssentialsSpawn, HideAndSeek, HungerGames, LaunchpadsSVG
[02:25:52 INFO]: LibsDisguises, MapsCompletedSVG, MobArena, MobHunting, Multiverse-Core, Multiverse-Inventories, Multiverse-NetherPortals, Multiverse-Portals, NameColorSVG, ParkourProSVG
[02:25:52 INFO]: PermissionsEx, PetShopSVG, PlotSquared, ProtocolLib, QuestsSVG, Spartan, SpawnDropSVG, SpawnSelectorSVG, SpigotProxy, SpleefSVG
[02:25:52 INFO]: TNTRun_reloaded, TutorialSVG, Vault, VipFlySVG, VIPHeadsSVG, VoidGen, VoteListenerSVG, Votifier, WorldEdit, WorldGuard

Other

It would be helpful if you would add an option to remove the queue and just instantly update the chunks, just like worldedit.
Also, this was how the old version of Biomes addon did it but now it is different and takes long.

@BONNe
Copy link
Member

BONNe commented Mar 12, 2023

BentoBox unlike WorldEdit uses Spigot API.

With Spigot API it is not possible to do things instantly. The time of changing biome depends on your island sizes. If you change biome in enormous area, then it will take time to load all chunks a d change biome in them.

You can speed it up by allowing multiple parallel biome changes in biomes config.

@BONNe BONNe closed this as completed Mar 12, 2023
@BONNe BONNe reopened this Mar 12, 2023
@Waterman1001
Copy link
Author

Thank you so much for your reply!
I do understand your point, although I am a little confused to why this was working in the older versions of the Biomes addon then? An now suddenly this has changed. I am fine on the area first having to unload, e.g. by requiring the player to relog.

Additionally, I still feel like the queue should not include the biome change for this specific island anymore, if this island has been deleted in the meantime.

@BONNe BONNe added Status: Pending Waiting for a developer to start working on this issue. Type: Enhancement Improvement or modification which is usually a new feature. labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Waiting for a developer to start working on this issue. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
Development

No branches or pull requests

2 participants