Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dark theme more visually pleasing #9

Closed
Dreamedc2015 opened this issue May 18, 2021 · 8 comments
Closed

Make dark theme more visually pleasing #9

Dreamedc2015 opened this issue May 18, 2021 · 8 comments
Labels
CSS Issues pertaining to CSS good first issue Good for newcomers
Milestone

Comments

@Dreamedc2015
Copy link
Contributor

The dark theme seems a bit to contrasty and could do with more matching to the jekyll wiki's dark theme

@Dreamedc2015 Dreamedc2015 added good first issue Good for newcomers CSS Issues pertaining to CSS labels May 18, 2021
@Dreamedc2015 Dreamedc2015 added this to the v1.0 Release milestone May 18, 2021
@solvedDev
Copy link
Contributor

The theme is inline with bedrock.dev (apart from tables). Not sure whether it's worth moving away from this consistency

@SirLich
Copy link
Contributor

SirLich commented May 20, 2021

@solvedDev Theme isn't a perfect match. Tables are one good example:
image

@solvedDev
Copy link
Contributor

Yep, that's what I also mentioned as an example inside of my comment. I don't agree that it should look like the old Wiki though if we still want consistency with bedrock.dev

@Joelant05
Copy link
Contributor

I've pushed a change to the table's colors to make them consistent with bedrock.dev

c212dde

@solvedDev
Copy link
Contributor

Looks great 👍

@solvedDev
Copy link
Contributor

What are the other changes you have in mind? From my point of view, the issue should have been closed by c212dde

@SirLich @Dreamedc2015

@solvedDev
Copy link
Contributor

If we have other things to fix/change, we should probably create more concrete issues for them

@SirLich
Copy link
Contributor

SirLich commented May 20, 2021

Looks good. Agreed on all points. Closing.

@SirLich SirLich closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Issues pertaining to CSS good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants