Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sidebar pip in-page as well #19

Closed
SirLich opened this issue May 19, 2021 · 4 comments
Closed

Show sidebar pip in-page as well #19

SirLich opened this issue May 19, 2021 · 4 comments
Assignees
Labels
JS/VUE Issues pertaining to JS or VUE
Milestone

Comments

@SirLich
Copy link
Contributor

SirLich commented May 19, 2021

Currently we need to write it into the title, or add it below as a widget. Can we just make sidebar pips display in the title too?

image

@SirLich SirLich added the JS/VUE Issues pertaining to JS or VUE label May 19, 2021
@SirLich SirLich added this to the v1.1 Release milestone May 19, 2021
@solvedDev
Copy link
Contributor

We already have a system similar to this. We should be able to reuse it:

image
image

@SirLich
Copy link
Contributor Author

SirLich commented May 20, 2021

Yes! I'm aware. I'm simply looking into using The Layout (or a custom Layout!) to do it automatically.

I want to avoid as much double-work as possible when writing pages. If something is marked beta in the sidebar, I want it to be marked beta on the page as well.

@SirLich SirLich self-assigned this May 20, 2021
@solvedDev
Copy link
Contributor

Ah, I see. This should be an easy fix if we remove all <h1> headers from the markdown itself and instead have the page title inside of the frontmatter too

@SirLich
Copy link
Contributor Author

SirLich commented May 20, 2021

Page title is already inside the front-matter, I believe. That's how we generate sidebar content.

I'm still deciding whether I'm fully happy with that solution or not. Currently we sometimes use a different (shorter) title for the sidebar, and provide more information for the in-page h1.

But I will look into it. Still working on cracking the custom layouts.

@SirLich SirLich closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS/VUE Issues pertaining to JS or VUE
Projects
None yet
Development

No branches or pull requests

2 participants