Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Form components #70

Open
2 tasks
FabienEssid opened this issue Mar 1, 2021 · 0 comments
Open
2 tasks

Improve Form components #70

FabienEssid opened this issue Mar 1, 2021 · 0 comments
Assignees
Projects

Comments

@FabienEssid
Copy link
Contributor

We would like to improve our form components to have a better development experience and to optimize the code.
I think we could do some research for those things :

  • Create a "sub" v-text-field component for example which take a prop to remove the following lines :
@input="$v.scope.field.$touch()"
@blur=$v.scope.field.$touch()"
  • Create a mixin to put some code inside it and to remove this code in components. For example :
  • requiredErrors method
  • isValidForm, a new method to remove the following lines in onSubmit methods :
this.$v.$touch();
if (this.$v.$invalid) return;
@FabienEssid FabienEssid self-assigned this Mar 1, 2021
@FabienEssid FabienEssid linked a pull request Mar 1, 2021 that will close this issue
@medamineziraoui medamineziraoui added this to To do in Task Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Task
To do
Development

Successfully merging a pull request may close this issue.

1 participant