Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash if exception or promise is rejected #41

Open
medamineziraoui opened this issue Feb 19, 2021 · 2 comments
Open

App crash if exception or promise is rejected #41

medamineziraoui opened this issue Feb 19, 2021 · 2 comments
Labels
🐞 Bug Something isn't working

Comments

@medamineziraoui
Copy link
Collaborator

medamineziraoui commented Feb 19, 2021

Currently the hole app crash if an exception or promise is rejected, we need to prevent that and make sure that a failure in the execution won't cause the application to crash

@medamineziraoui
Copy link
Collaborator Author

medamineziraoui commented Feb 19, 2021

  • Check if we can prevent that from happening in the express part, until this moment I didn't find evidence that this is possible, we need to always provide next() and handle correctly
  • Add a system at node level to handle crashes.
  • Add system to shutdown instance gracefully
  • Add system to add workers, this will allow us to add more instances and restart them if they fail. use previous version of throng lib

@Jessy-BAER Jessy-BAER added this to To do in Task Feb 19, 2021
@Jessy-BAER Jessy-BAER moved this from To do to In progress in Task Feb 19, 2021
@medamineziraoui medamineziraoui moved this from In progress to In review in Task Feb 22, 2021
@medamineziraoui
Copy link
Collaborator Author

  • Add PM2 to current project

@medamineziraoui medamineziraoui moved this from In review to Refused in Task Feb 27, 2021
@medamineziraoui medamineziraoui moved this from Refused to To do in Task Mar 1, 2021
@the2ne the2ne added the 🐞 Bug Something isn't working label Jun 30, 2021
@the2ne the2ne added this to To do in Bug tracking Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working
Projects
Task
To do
Development

No branches or pull requests

2 participants