small bugs and small improvements #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antran89 looking at this function, it seems that the last line of the kernel should also be updated to: |
|
@Yangqing no worries -- I was just checking to make sure, thanks :) |
| @@ -149,7 +149,7 @@ __global__ void StoPoolForwardTest(const int nthreads, | |||
| cumvalues += bottom_slice[h * width + w] * bottom_slice[h * width + w]; | |||
| } | |||
| } | |||
| top_data[index] = cumvalues / cumsum; | |||
| top_data[index] = (cumsum > 0.) ? cumvalues / cumsum : 0.; | |||
There was a problem hiding this comment.
Is the test for cumsum > 0. correct here. Do we not allow negative values?
There was a problem hiding this comment.
Negative values aren't valid for stochastic pooling. The input represents values in a probability distribution (though it doesn't have to be normalized to sum to 1).
beniz
pushed a commit
to jolibrain/caffe
that referenced
this pull request
Jul 10, 2017
minor fix to stochastic pooling and clean-up of mean computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses small improvements in Caffe codes such as small programming bugs, typos and etc.
cumsumshould be initialized as0.for cumulative sum. I have not tested it, but logically, it should be initialized with0..