Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with placing input ASTs for a case with complex region shape #779

Open
galaxyumi opened this issue Nov 2, 2022 · 2 comments
Open

Comments

@galaxyumi
Copy link
Contributor

While working on one galaxy with a complicated foot print, I found that the BEAST places input ASTs in the area outside the reference image, which is waste of our resources. This happens when the convex hull technique is not valid.

I am attaching an example where the convex hull method does not work properly. The left panel shows the observed stellar density map where I want to place input ASTs. The right panel shows the density map of input ASTs generated from the BEAST. As you can see from these plots, the BEAST places input ASTs in the left and right sides of the real source density map where they are in fact empty.

convexhull_failing_example

We need to replace the convex hull method to another one that can handle any kind of complex boundary shapes.

@christinawlindberg
Copy link
Contributor

Just brainstorming about this issue a little bit. I don't think the issue is that the convex hull isn't working properly, it's more the case that what you really need is a concave hull, which would allow for inside angles greater than 180 deg).
image

I managed to find a python code snippet online that uses Delaunay triangulation to create a convex hull around a set of datapoints. Using this method would require manually setting an "alpha" value for how pliable the edges should be, meaning that there should probably be some sort of visual diagnostic to check that the appropriate "alpha" value is being set.
image

@christinawlindberg
Copy link
Contributor

#789 should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants