Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot put more than two comments on the same line #772

Closed
shenglol opened this issue Nov 2, 2020 · 0 comments · Fixed by #9104
Closed

Cannot put more than two comments on the same line #772

shenglol opened this issue Nov 2, 2020 · 0 comments · Fixed by #9104
Assignees
@shenglol
Labels
bug Something isn't working
Milestone
v0.13

Comments

@shenglol
Copy link
Contributor

shenglol commented Nov 2, 2020 •
edited
Loading

Bicep version
The latest build.

Describe the bug
Bumped into this while writing tests for the code formatter. It seems that each token can have at most one leading comment and one trailing comment. That's why you can only put one comment on the first line.
image

To Reproduce
Put more than two comments on the same line.
@ghost ghost added the Needs: Triage 🔍 label Nov 2, 2020
@shenglol shenglol added bug Something isn't working and removed Needs: Triage 🔍 labels Nov 2, 2020
@shenglol shenglol added this to the v0.3 milestone Nov 13, 2020
@shenglol shenglol self-assigned this Nov 13, 2020
@shenglol shenglol added this to To Do in 0.3 release Dec 16, 2020
@TSunny007 TSunny007 moved this from To Do to In Progress in 0.3 release Dec 22, 2020
@TSunny007 TSunny007 assigned TSunny007 and unassigned shenglol Dec 22, 2020
@TSunny007 TSunny007 moved this from In Progress to To Do in 0.3 release Dec 22, 2020
@TSunny007 TSunny007 assigned shenglol and unassigned TSunny007 Dec 22, 2020
@alex-frankel alex-frankel modified the milestones: v0.3, Committed Backlog Mar 3, 2021
@alex-frankel alex-frankel removed this from To Do in 0.3 release Mar 3, 2021
@alex-frankel alex-frankel modified the milestones: Committed Backlog, v0.4 Mar 22, 2021
@alex-frankel alex-frankel modified the milestones: v0.4, v0.5 Jun 3, 2021
@stephaniezyen stephaniezyen modified the milestones: v0.5, v0.6 Mar 11, 2022
@stephaniezyen stephaniezyen added the good first issue Good for newcomers label Mar 11, 2022
@alex-frankel alex-frankel modified the milestones: v0.6, v1.0 Mar 25, 2022
@stephaniezyen stephaniezyen removed the good first issue Good for newcomers label May 16, 2022
@stephaniezyen stephaniezyen modified the milestones: v1.0, Committed Backlog May 16, 2022
@shenglol shenglol mentioned this issue Nov 23, 2022
Merged
@shenglol shenglol modified the milestones: Committed Backlog, v0.13 Nov 23, 2022
@shenglol shenglol self-assigned this Nov 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shenglol shenglol

Labels
bug Something isn't working
Projects
Bicep
Archived in project
Milestone
v0.13
Development

Successfully merging a pull request may close this issue.

Allow more than two block comments on the same line Azure/bicep
4 participants
@TSunny007 @alex-frankel @shenglol @stephaniezyen