Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make live tests required PR checks #6835

Open
shenglol opened this issue May 12, 2022 · 0 comments
Open

Make live tests required PR checks #6835

shenglol opened this issue May 12, 2022 · 0 comments
Labels
tech debt Fixing this issue will pay down technical debt we have accumulated.

Comments

@shenglol
Copy link
Contributor

Currently the live tests are optional checks, and they are skipped for PRs sent from forks. However, failures in the live tests are usually ignored blindly as the test credentials expire quite often. We should consider making them required checks instead to force people to go through the error messages. This can help prevent regressions like #6823.

One thing we need to figure out is how to make the checks pass silently for PRs sent from forks, since required checks cannot be skipped (https://github.community/t/feature-request-conditional-required-checks/16761).

@ghost ghost added the Needs: Triage 🔍 label May 12, 2022
@alex-frankel alex-frankel added tech debt Fixing this issue will pay down technical debt we have accumulated. and removed Needs: Triage 🔍 labels May 16, 2022
@alex-frankel alex-frankel added this to the Committed Backlog milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Fixing this issue will pay down technical debt we have accumulated.
Projects
None yet
Development

No branches or pull requests

2 participants