Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter IntelliSense completions by declaration type #661

Open
majastrz opened this issue Oct 16, 2020 · 1 comment
Open

Filter IntelliSense completions by declaration type #661

majastrz opened this issue Oct 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@majastrz
Copy link
Member

We should not be suggesting the concat() function if the contextual/declared type at the current position is not string or one of its subtypes.

@majastrz majastrz added the enhancement New feature or request label Oct 16, 2020
@ghost ghost added the Needs: Triage 🔍 label Oct 16, 2020
@majastrz
Copy link
Member Author

Thought about it some more...

I think the safest way would be to filter out functions that return simple types (string, bool, int) when the contextual type of the property isn't compatible. We should still allow functions that return objects because when they user is assigning location of a resource, they would want to see the completion for resourceGroup() so they can use . to access the location property of the RG.

@alex-frankel alex-frankel added this to the v0.3 milestone Oct 21, 2020
@alex-frankel alex-frankel added this to To Do in 0.3 release Nov 16, 2020
@alex-frankel alex-frankel added this to To do in 0.4 release via automation Mar 8, 2021
@alex-frankel alex-frankel removed this from To Do in 0.3 release Mar 8, 2021
@alex-frankel alex-frankel modified the milestones: v0.3, v0.4 Mar 8, 2021
@alex-frankel alex-frankel removed this from To do in 0.4 release May 10, 2021
@alex-frankel alex-frankel modified the milestones: v0.4, Committed Backlog May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants