Replace the provider keyword with the extension keyword
#14379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 9650842308) VSCode
Azure CLI
|
| @@ -23,7 +23,7 @@ public class CentralizedProviderVersionManagementTests : TestBase | |||
| public void ProvidersConfig_SupportForConfigManagedProviderDeclarationSyntax_When_ProviderIsBuiltIn(string providerIdentifier, bool shouldSucceed, (string code, DiagnosticLevel level, string message)[] expectedDiagnostics) | |||
| { | |||
| var result = CompilationHelper.Compile(Services, @$" | |||
| provider {providerIdentifier} | |||
| extension {providerIdentifier} | |||
There was a problem hiding this comment.
As you mentioned in the PR description, will providerIdentifier be changed in another PR?
There was a problem hiding this comment.
Yeah, this is tracked by #14375.
harshpatel17
approved these changes
Jun 21, 2024
|
@rynowak fyi you already missed out on being able to use |
Good change 👍 The term |
|
/cc @shruthikumar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the first step of addressing #14374, this PR replaces the provider keyword with the extension keyword. Using the provider keyword will now trigger a warning diagnostic with a code fix to assist users in migrating to the new keyword.
To reduce the scope of this PR, the use of
providerwithin the Bicep CLI, Bicep configuration, and the codebase will be replaced separately in subsequent PRs.Closes #14378.
Microsoft Reviewers: Open in CodeFlow