Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var to ref git sha1 or version info in becep #13037

Open
tg123 opened this issue Jan 18, 2024 · 5 comments
Open

var to ref git sha1 or version info in becep #13037

tg123 opened this issue Jan 18, 2024 · 5 comments
Labels
enhancement New feature or request Needs: Upvote This issue requires more votes to be considered

Comments

@tg123
Copy link

tg123 commented Jan 18, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

var ver = deployment().properties.cvsver

resource xxx xxx = {
 name: '{xxx$ver}
}

Describe the solution you'd like
A clear and concise description of what you want to happen.

add version info into deployment() or some other build time/runtime obj

@tg123 tg123 added the enhancement New feature or request label Jan 18, 2024
@stephaniezyen
Copy link
Contributor

Can you please give more information on what you are looking for and what issue you are having?

@stephaniezyen stephaniezyen added Needs: Author Feedback Awaiting feedback from the author of the issue and removed Needs: Triage 🔍 labels Jan 24, 2024
@tg123
Copy link
Author

tg123 commented Jan 27, 2024

bicep build put some meta info into output.json

for exmaple

  "metadata": {
    "_generator": {
      "name": "bicep",
      "version": "0.24.24.22086",
      "templateHash": "2004619805940471825"
    }
  },

could bicep add git sha1 or some version info, so it is easier to track version deployed

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 and removed Needs: Author Feedback Awaiting feedback from the author of the issue labels Jan 27, 2024
@jeskew
Copy link
Contributor

jeskew commented Jan 31, 2024

The git sha is probably a little too specific to a particular project structure to be implemented within Bicep core. @tg123 would your needs be covered by something like #7259?

@jeskew jeskew added Needs: Author Feedback Awaiting feedback from the author of the issue and removed Needs: Triage 🔍 labels Jan 31, 2024
@tg123
Copy link
Author

tg123 commented Feb 2, 2024

go support build vcs info to final binary
https://portal.microsofticm.com/imp/v3/incidents/details/459821378/home

i think bicep can do the same

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 and removed Needs: Author Feedback Awaiting feedback from the author of the issue labels Feb 2, 2024
@jeskew
Copy link
Contributor

jeskew commented Feb 2, 2024

Make sense! Triaging as a standalone feature request.

If we do ship #7259 before anyone works on this (and since this task has no milestone, there is no guarantee that anyone will ever pick this up), there will be a viable way to do this without explicit support in the Bicep compiler.

@jeskew jeskew added Needs: Upvote This issue requires more votes to be considered and removed Needs: Triage 🔍 labels Feb 2, 2024
@jeskew jeskew removed their assignment Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs: Upvote This issue requires more votes to be considered
Projects
Status: Todo
Development

No branches or pull requests

3 participants