Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporters fail when global tracer provider isn't set. #36362

Open
avramdj opened this issue Jul 4, 2024 · 1 comment
Open

Exporters fail when global tracer provider isn't set. #36362

avramdj opened this issue Jul 4, 2024 · 1 comment
Assignees
@lzchen
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team.

Comments

@avramdj
Copy link

avramdj commented Jul 4, 2024 •
edited
Loading

azure-sdk-for-python/sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_exporter.py

Line 86 in 8b6e24d

tracer_provider = get_tracer_provider()

Why not let tracer_provider be a kwarg in BaseExporter? It's useful in complex systems where you have multiple providers (e.g reinitializing tracer providers in forks). It's also a step towards letting people opt out of global state, which (to me) is a very iffy part of the opentelemetry ecosystem.

I'd be willing to add a little PR. Afaik all that's needed is a kwarg line in BaseExporter.__init__ and something like tracer_provider = self._tracer_provider or get_tracer_provider() wherever get_tracer_provider() is being called in it's subclasses
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. labels Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @hectorhdzg @jeremydvoss @lzchen.

@avramdj avramdj mentioned this issue Jul 4, 2024
Open
6 tasks
@mccoyp mccoyp added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention This issue needs attention from Azure service team or SDK team Service Attention This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lzchen @mccoyp @avramdj