Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure client request id and other headers are added only once on retries. #8920

Closed
annelo-msft opened this issue Nov 26, 2019 · 2 comments
Closed
Assignees
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Nov 26, 2019

Per Partner request:

Can you please confirm that the client request id won’t be repeated on retry too? Because client request id is not involved in HMAC signing, I am not sure if it’s fixed as part of the signing issue.

This is the real log of the response that the customer reported.

clientReqId

So looks like this is what happened

  1. The SDK sent the initial request with x-ms-client-request-id: 0453ca94-5026-4fa0-aeee-ea38de69cfd5
  2. The request is throttled and the server responded 429 (this is the first log I shared earlier)
  3. The SDK retry for 429 and sent a request with x-ms-client-request-id: 0453ca94-5026-4fa0-aeee-ea38de69cfd5, 0453ca94-5026-4fa0-aeee-ea38de69cfd5
  4. The server responded 401 likely due to the SDK HMAC signing issue you mentioned
  5. The SDK won’t retry for 401 and the exception bubbled up.

Looks like when SDK retries, it doubles the client request id string. Is this fixed already?

@annelo-msft annelo-msft added App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library. labels Nov 26, 2019
@annelo-msft annelo-msft added this to the [2020] January milestone Dec 4, 2019
@annelo-msft
Copy link
Member Author

Action here is to add test to verify this doesn't happen in the current release.

@annelo-msft annelo-msft changed the title Ensure client request id is added only once on retries. Ensure client request id and other headers are added only once on retries. Dec 4, 2019
@AlexanderSher AlexanderSher self-assigned this Dec 5, 2019
@AlexanderSher
Copy link
Contributor

Closed by #8986

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

3 participants