Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated container-group-profile commands and added container group properties for reuse scenario #26604

Conversation

kaushik-ms
Copy link
Contributor

@kaushik-ms kaushik-ms commented Nov 5, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Nov 5, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.ContainerInstance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzContainerGroup Get-AzContainerGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerGroup Get-AzContainerGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceCachedImage Get-AzContainerInstanceCachedImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceCachedImage Get-AzContainerInstanceCachedImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceCapability Get-AzContainerInstanceCapability Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceCapability Get-AzContainerInstanceCapability changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceContainerGroupProfile Get-AzContainerInstanceContainerGroupProfile Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceContainerGroupProfile Get-AzContainerInstanceContainerGroupProfile changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceContainerGroupProfileRevision Get-AzContainerInstanceContainerGroupProfileRevision Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceContainerGroupProfileRevision Get-AzContainerInstanceContainerGroupProfileRevision changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceLog Get-AzContainerInstanceLog Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceLog Get-AzContainerInstanceLog changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzContainerInstanceUsage Get-AzContainerInstanceUsage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzContainerInstanceUsage Get-AzContainerInstanceUsage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerGroupImageRegistryCredentialObject New-AzContainerGroupImageRegistryCredentialObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerGroupPortObject New-AzContainerGroupPortObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerGroupVolumeObject New-AzContainerGroupVolumeObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstanceEnvironmentVariableObject New-AzContainerInstanceEnvironmentVariableObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstanceHttpHeaderObject New-AzContainerInstanceHttpHeaderObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstanceInitDefinitionObject New-AzContainerInstanceInitDefinitionObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstanceNoDefaultObject New-AzContainerInstanceNoDefaultObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstanceObject New-AzContainerInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstancePortObject New-AzContainerInstancePortObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzContainerInstanceVolumeMountObject New-AzContainerInstanceVolumeMountObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzContainerGroup 2 3 Mismatched_Parameter_Value_Type New-AzContainerInstanceEnvironmentVariableObject -SecureValue $pwd is not an expected parameter value type. -SecureValue Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerGroup 4 3 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerGroup 5 3 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerGroup 6 2 Mismatched_Parameter_Value_Type New-AzContainerGroupVolumeObject -AzureFileStorageAccountKey $pwd is not an expected parameter value type. -AzureFileStorageAccountKey Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerGroupImageRegistryCredentialObject 1 2 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerGroupVolumeObject 1 2 Mismatched_Parameter_Value_Type New-AzContainerGroupVolumeObject -AzureFileStorageAccountKey $pwd is not an expected parameter value type. -AzureFileStorageAccountKey Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerInstanceContainerGroupProfile 2 3 Mismatched_Parameter_Value_Type New-AzContainerInstanceEnvironmentVariableObject -SecureValue $pwd is not an expected parameter value type. -SecureValue Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerInstanceContainerGroupProfile 3 3 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
⚠️ New-AzContainerInstanceEnvironmentVariableObject 2 2 Mismatched_Parameter_Value_Type New-AzContainerInstanceEnvironmentVariableObject -SecureValue $pwd is not an expected parameter value type. -SecureValue Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ContainerInstance. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@kaushik-ms
Copy link
Contributor Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 26604 in repo Azure/azure-powershell

@dolauli
Copy link
Contributor

dolauli commented Nov 5, 2024

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Nov 6, 2024

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli removed their assignment Nov 6, 2024
@kaushik-ms
Copy link
Contributor Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 26604 in repo Azure/azure-powershell

@vidai-msft
Copy link
Contributor

@kaushik-ms Please fix the static analysis issue as detected in the CI.

@vidai-msft vidai-msft self-assigned this Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@drishtipeshwani09
Copy link

Az.ContainerInstance 4.0.3

  • Added ContainerGroupProfileId ContainerGroupProfileRevision StandbyPoolProfileFailContainerGroupCreateOnReuseFailure StandbyPoolProfileId to Container Group properties.
  • Added ConfigMapKeyValuePair to Container object properties.
  • Added new cmdlet to define container without using the preset default properties New-AzContainerInstanceNoDefaultObject
  • Added new cmdlets for Container Group Profile - Get-AzContainerInstanceContainerGroupProfile, New-AzContainerInstanceContainerGroupProfile, Remove-AzContainerInstanceContainerGroupProfile, Update-AzContainerInstanceContainerGroupProfile, Get-AzContainerInstanceContainerGroupProfileRevision
  • For Container Group properties, the default value for OsType is no longer preset to Linux and has to be explicitly specified.

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft merged commit 4feee22 into Azure:generation Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants