-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated container-group-profile commands and added container group properties for reuse scenario #26604
Generated container-group-profile commands and added container group properties for reuse scenario #26604
Conversation
…properties for reuse scenario
️✔️Az.Accounts
|
Type | Cmdlet | Description | Remediation |
---|---|---|---|
Get-AzContainerGroup | Get-AzContainerGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerGroup | Get-AzContainerGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceCachedImage | Get-AzContainerInstanceCachedImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceCachedImage | Get-AzContainerInstanceCachedImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceCapability | Get-AzContainerInstanceCapability Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceCapability | Get-AzContainerInstanceCapability changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint | Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint | Get-AzContainerInstanceContainerGroupOutboundNetworkDependencyEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceContainerGroupProfile | Get-AzContainerInstanceContainerGroupProfile Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceContainerGroupProfile | Get-AzContainerInstanceContainerGroupProfile changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceContainerGroupProfileRevision | Get-AzContainerInstanceContainerGroupProfileRevision Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceContainerGroupProfileRevision | Get-AzContainerInstanceContainerGroupProfileRevision changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceLog | Get-AzContainerInstanceLog Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceLog | Get-AzContainerInstanceLog changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
Get-AzContainerInstanceUsage | Get-AzContainerInstanceUsage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
Get-AzContainerInstanceUsage | Get-AzContainerInstanceUsage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerGroupImageRegistryCredentialObject | New-AzContainerGroupImageRegistryCredentialObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerGroupPortObject | New-AzContainerGroupPortObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerGroupVolumeObject | New-AzContainerGroupVolumeObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstanceEnvironmentVariableObject | New-AzContainerInstanceEnvironmentVariableObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstanceHttpHeaderObject | New-AzContainerInstanceHttpHeaderObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstanceInitDefinitionObject | New-AzContainerInstanceInitDefinitionObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstanceNoDefaultObject | New-AzContainerInstanceNoDefaultObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstanceObject | New-AzContainerInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstancePortObject | New-AzContainerInstancePortObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
New-AzContainerInstanceVolumeMountObject | New-AzContainerInstanceVolumeMountObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzContainerGroup 2 3 Mismatched_Parameter_Value_Type New-AzContainerInstanceEnvironmentVariableObject -SecureValue $pwd is not an expected parameter value type. -SecureValue Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerGroup 4 3 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerGroup 5 3 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerGroup 6 2 Mismatched_Parameter_Value_Type New-AzContainerGroupVolumeObject -AzureFileStorageAccountKey $pwd is not an expected parameter value type. -AzureFileStorageAccountKey Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerGroupImageRegistryCredentialObject 1 2 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerGroupVolumeObject 1 2 Mismatched_Parameter_Value_Type New-AzContainerGroupVolumeObject -AzureFileStorageAccountKey $pwd is not an expected parameter value type. -AzureFileStorageAccountKey Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerInstanceContainerGroupProfile 2 3 Mismatched_Parameter_Value_Type New-AzContainerInstanceEnvironmentVariableObject -SecureValue $pwd is not an expected parameter value type. -SecureValue Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerInstanceContainerGroupProfile 3 3 Mismatched_Parameter_Value_Type New-AzContainerGroupImageRegistryCredentialObject -Password $pwd is not an expected parameter value type. -Password Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static). ⚠️ New-AzContainerInstanceEnvironmentVariableObject 2 2 Mismatched_Parameter_Value_Type New-AzContainerInstanceEnvironmentVariableObject -SecureValue $pwd is not an expected parameter value type. -SecureValue Use correct parameter value type. Expected Type is securestring. Now the type is System.Object.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ContainerInstance. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
/azp run |
Commenter does not have sufficient privileges for PR 26604 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 26604 in repo Azure/azure-powershell |
@kaushik-ms Please fix the static analysis issue as detected in the CI. |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
…' of https://github.com/kaushik-ms/azure-powershell into feature_containerinstance/new_cmdlets_20240501preview
This reverts commit c9e9c6f.
… nullable[double] is not a breaking change (false positive)
Az.ContainerInstance 4.0.3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.