chore: tolerate lowercase LB SKU vals #1838
Conversation
| @@ -306,6 +306,12 @@ func (cs *ContainerService) setOrchestratorDefaults(isUpgrade, isScale bool) { | |||
| } | |||
| } | |||
|
|
|||
| if strings.ToLower(a.OrchestratorProfile.KubernetesConfig.LoadBalancerSku) == strings.ToLower(BasicLoadBalancerSku) { | |||
There was a problem hiding this comment.
Here we are doing some "convenient" string rationalization so that by the time we compose our Azure API spec, we are always using LB SKU values of the "capitalized" form.
| @@ -276,6 +276,12 @@ func (a *Properties) ValidateOrchestratorProfile(isUpdate bool) error { | |||
| } | |||
| } | |||
|
|
|||
| if o.KubernetesConfig.LoadBalancerSku != "" { | |||
There was a problem hiding this comment.
We were never actually doing basic SKU value validation for vlabs. Here we check against case-insensitive variants of "basic" and "standard"
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
==========================================
+ Coverage 76.41% 76.42% +<.01%
==========================================
Files 130 130
Lines 19413 19421 +8
==========================================
+ Hits 14835 14843 +8
Misses 3780 3780
Partials 798 798 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Explicitly tolerate both "basic" and "Basic", and "standard" and "Standard" as values for
kubernetesConfig.loadBalancerSku; and then do a conversion to the capitalized values before sending to Azure API.(In fact we are tolerating all variants of "basiC", "STANDaRD", etc etc)
Issue Fixed:
Requirements:
Notes: