Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

style: read without -r will mangle backslashes #1790

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:
Warns about read interpreting backslashes by default in unexpected ways.

See https://github.com/koalaman/shellcheck/wiki/SC2162

Issue Fixed:
Refs #953

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1790 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1790   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files         130      130           
  Lines       19351    19351           
=======================================
  Hits        14783    14783           
  Misses       3771     3771           
  Partials      797      797

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Aug 16, 2019
@acs-bot acs-bot merged commit 5d82ebb into Azure:master Aug 16, 2019
@acs-bot
Copy link

acs-bot commented Aug 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the shellcheck-2162 branch August 16, 2019 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants