Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: use numeric address to avoid DNS reverse lookup #1769

Merged
merged 2 commits into from
Aug 15, 2019
Merged

chore: use numeric address to avoid DNS reverse lookup #1769

merged 2 commits into from
Aug 15, 2019

Conversation

haitch
Copy link
Member

@haitch haitch commented Aug 12, 2019

Reason for Change:

  • avoid DNS reverse lookup when starting kubelet
    • in some case custom dns server used in vNet, quality of their DNS is not guaranteed, which could block kubelet service start.

I did compare impact of this change, only different is it displays 0.0.0.0/0 instead of anywhere, for a clean aks cluster.

Issue Fixed:

Requirements:

Notes:

@welcome
Copy link

welcome bot commented Aug 12, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@mboersma
Copy link
Member

/azp run pr-e2e

@mboersma
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma
Copy link
Member

@haitch thanks!

It failed the generated files check, so you need to run make generate and commit the results to this PR.

@mboersma
Copy link
Member

/ok-to-test

@haitch
Copy link
Member Author

haitch commented Aug 13, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1769 in repo Azure/aks-engine

@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis
Copy link
Member

@yangl900 should sign off on this

@mboersma mboersma requested a review from yangl900 August 15, 2019 20:49
@yangl900
Copy link
Contributor

/LGTM

@acs-bot
Copy link

acs-bot commented Aug 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haitch, mboersma, yangl900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit bcf9101 into Azure:master Aug 15, 2019
@welcome
Copy link

welcome bot commented Aug 15, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants