This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: use k8s test infra archive for nssm.exe #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: https://nssm.cc just came back from the dead, but since this is at least the second time it's gone down (and this time, for more than a week!), the k8s test infra archive will be more stable. |
|
/lgtm |
jackfrancis
approved these changes
Jul 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
make build-windows-k8sbegan failing since the website https://nssm.cc is not accessible, so let's fetch it from a stable archive instead.Issue Fixed:
Requirements:
Notes:
I used this change to create the Windows archive for #1694, so it has been tested. ✔️