-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we allow FeatureFlag.enabled to be "true"/"false" (string type)? #918
Comments
Looks like an oversight in the samples. |
These were added as we don't say we support String. But all of our libraries support Strings. |
Implementation for different platforms can vary, sometimes, for compatibility reasons, but the official samples shouldn't violate the schema. |
@mrm9084 can you take the fix for this? |
I have it fixed locally, just haven't got the PR up yet. Was trying to finish something else first. |
Fixed in this PR #923 |
Given
FeatureFlag.enabled
is defined as boolean type in the schema, is it proper to support "true"/"false" of string type, especially in official samples?Schema:
AppConfiguration/docs/FeatureManagement/FeatureFlag.v2.0.0.schema.json
Lines 43 to 46 in d0ef7d5
Samples:
AppConfiguration/docs/FeatureManagement/Samples/NoFilters.sample.json
Lines 21 to 35 in d0ef7d5
The text was updated successfully, but these errors were encountered: