Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal: We should add a text indicating the connection string and key type/value should be presented in a fixed order (Primary, Secondary) #24

Closed
zhenlan opened this issue Jan 29, 2019 · 6 comments
Assignees
Labels
portal Issues relating to the AppConfig portal.
Milestone

Comments

@zhenlan
Copy link
Contributor

zhenlan commented Jan 29, 2019

We should have "Connection String" in front of the connection string box.
image

In addition, in the screenshot above, the "Secondary" comes before the "Primary", which sounds like another bug.

@zhenlan zhenlan added the portal Issues relating to the AppConfig portal. label Jan 29, 2019
@zhenlan zhenlan added this to the Preview milestone Jan 29, 2019
@zhenlan
Copy link
Contributor Author

zhenlan commented Jan 29, 2019

Alternatively, we can have "Primary Connection String", "Secondary Connection String" etc.

@mlacouture
Copy link
Member

it seems the issue with the secondary key before the primary key is fixed, I can't reproduce it.

@mlacouture
Copy link
Member

The subtitles "Primary", "Secondary", and corresponding RO values come from the server ...

@mlacouture
Copy link
Member

The key name order follows the order keys are recreated, it should be a fixed order. And the string that comes from the server needs to be translated into one provided by the portal (localizable and containing the connection string words).

@zhenlan
Copy link
Contributor Author

zhenlan commented Feb 7, 2019

The service (RP) won't guarantee the order of keys and the portal should not depend on it.
The service (RP) won't have localized strings. The portal should own the resource strings.

Therefore, the portal should

  • Check the Primary or Secondary (in addition to the read-only field) and order the keys properly
  • Write label for each output box (eg. "Primary", "Secondary" and "Connection string"). This will be localized by the portal.

@mlacouture mlacouture changed the title We should add a text indicating the connection string Portal: We should add a text indicating the connection string and key type/value should be presented in a fixed order (Primary, Secondary) Feb 7, 2019
@mlacouture
Copy link
Member

Fixed committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portal Issues relating to the AppConfig portal.
Projects
None yet
Development

No branches or pull requests

2 participants