Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update existing secrets from the 1.3.0 version #32

Closed
antoineozenne-at-leocare opened this issue Apr 22, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@antoineozenne-at-leocare
Copy link

antoineozenne-at-leocare commented Apr 22, 2024

I updated from version 1.2.0 to 1.3.0, but I have the following error for all my secrets (with a verbosity to 5):

I0422 13:02:14.590953       1 appconfigurationprovider_controller.go:396] No secret settings are fetched from Azure AppConfiguration
W0422 13:02:14.672973       1 appconfigurationprovider_controller.go:316] Fail to update the target ConfigMap or Secret of AzureAppConfigurationProvider 'foo' in 'bar' namespace: secrets "foo" is forbidden: User "system:serviceaccount:azappconfig-system:az-appconfig-k8s-provider" cannot delete resource "secrets" in API group "" in the namespace "bar": Azure does not have opinion for this user.

I noticed that the existingSecrets variable is no longer a pointer in the version 1.3.0 in

if err := processor.PopulateSettings(&existingConfigMap, existingSecrets); err != nil {

I think this could be the cause of my problem. I did not change anything in my AzureAppConfigurationProvider resources which use secret.auth.workloadIdentity.managedIdentityClientIdReference.

@RichardChen820 RichardChen820 self-assigned this Apr 23, 2024
@RichardChen820 RichardChen820 added the bug Something isn't working label Apr 23, 2024
@RichardChen820
Copy link
Contributor

Regression in v1.3.0, while no secret is selected by the selectors, it fails to create an empty target Secret.

@RichardChen820
Copy link
Contributor

@antoineozenne-at-leocare The regression should be fixed in v1.3.1, could you give it another try?

@antoineozenne-at-leocare
Copy link
Author

@antoineozenne-at-leocare The regression should be fixed in v1.3.1, could you give it another try?

Now it works, thank you @RichardChen820!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants