Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lcobucci/jwt ^5.0 #35

Closed
ovidiuenache opened this issue Aug 3, 2023 · 3 comments
Closed

Add support for lcobucci/jwt ^5.0 #35

ovidiuenache opened this issue Aug 3, 2023 · 3 comments

Comments

@ovidiuenache
Copy link
Contributor

Hello! The lcobucci/jwt package has a new major version that is currently not supported (see https://packagist.org/packages/lcobucci/jwt). Can we please release a new version that adds support for it? Thank you!

@hywak
Copy link
Collaborator

hywak commented Aug 3, 2023

Hey @ovidiuenache,

Thank you for your issue report! Sure we can, feel free to submit a Pull request with the changes. It shouldn't be so difficult to add support to a new version, however, it's a major change so it might not be backward compatible.

@ovidiuenache
Copy link
Contributor Author

@hywak #36

@hywak
Copy link
Collaborator

hywak commented Aug 9, 2023

The PR you created was merged and tagged with 3.0.0

Thank you @ovidiuenache for your contribution <3

@hywak hywak closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants