Fix the mini player icon on first load #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue that when you open the app the mini player shows a pause icon when there isn't a podcast playing. It happens when the system changes between light and dark theme.
The core of the issue was that I was trying to set the Lottie drawable frame to the play icon in the custom view component init method. At this point the view hasn't been inflated yet so the drawable is null and can't have the frame set. To fix this I move setting the frame into the
onLayout
method and the drawable is not null.As part of this PR I also fixed some other things:
lottie_scale
has been removed.Fixes #148
device-2022-08-05-110346.mp4