Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look into changing over to brpoplpush #38

Open
tj opened this issue Jul 19, 2011 · 20 comments
Open

look into changing over to brpoplpush #38

tj opened this issue Jul 19, 2011 · 20 comments
Milestone

Comments

@tj
Copy link
Contributor

tj commented Jul 19, 2011

atomic goodness for queues, could get rid of my hack of a zpop

http:https://redis.io/commands/brpoplpush

@behrad behrad modified the milestones: 0.8.0, 0.7.1 Mar 27, 2014
@behrad behrad modified the milestones: 1.0.0, 0.8.0 May 5, 2014
@maboa
Copy link

maboa commented Jun 19, 2014

Any idea if/when this is coming? It looks like we could really do with this feature too!

Keep up the great work BTW and thanks! :)

@behrad
Copy link
Collaborator

behrad commented Jun 19, 2014

I'm thinking of doing this on a major version release, specifically 1.0.0 since it requires a very big code change, and kue redesign on redis sets/lists usage.

But you currently should have no problems in many deployment situations with the existing implementation.

@maboa
Copy link

maboa commented Jun 20, 2014

Thanks Behrad! afaict this will only be an issue if something fails. We need to detect that situation so we can resubmit.

@behrad
Copy link
Collaborator

behrad commented Jun 20, 2014

when something bad fails, everything can be an issue, event with the atomic brpoplpush

@pgte
Copy link

pgte commented Jun 20, 2014

As I see it, with atomic brpoplpush the work stays in redis. Without it, there's a brief windows between a pop and a push where, if the node.js process goes down, the work is lost. Am I right?

@behrad
Copy link
Collaborator

behrad commented Jun 20, 2014

right @pgte , in the current Kue code we have seen a couple of recovery codes from this situation

@behrad
Copy link
Collaborator

behrad commented Sep 11, 2014

A good example of how to provide priorities:
https://github.com/josiahcarlson/rpqueue/blob/master/rpqueue/__init__.py#L226

@behrad behrad self-assigned this Sep 11, 2014
@behrad behrad mentioned this issue Feb 24, 2015
@tj tj unassigned behrad Mar 24, 2015
@landau
Copy link

landau commented Jun 10, 2015

Any movement on this?

@behrad
Copy link
Collaborator

behrad commented Jun 10, 2015

I'd planned to start the refactoring to atomic Kue 1.0 early 2015, however it was my very busy days. I'm thinking of starting it in a few months, and remember this is a really huge refactoring effecting all Kue

@behrad
Copy link
Collaborator

behrad commented Jun 10, 2015

if you have a local redis instance (or one without poor network connection) you won't face queued stuck jobs. however active stuck jobs is something caused 95% by your app code.

@pawawat
Copy link

pawawat commented Sep 4, 2015

Hi,
Any progress on this?

@behrad
Copy link
Collaborator

behrad commented Sep 4, 2015

I've been very busy for a couple of months...

@vieks
Copy link

vieks commented Apr 20, 2016

up ?

@rturk
Copy link

rturk commented Oct 14, 2016

Hi @tj any plans to work on this?

@behrad
Copy link
Collaborator

behrad commented Oct 14, 2016

brpoplpush is one of methods of reaching atomicity/consistency but in favor of loosing priorities...
I don't want to drop priority queues, and implementing them with brpoplpush adds some complexities.
Another method is using lua scripts which is being preferred and implemented in v1 branch currently.

@rturk
Copy link

rturk commented Jan 15, 2017

@behrad. That's the point: atomicity/consistency is very important for me, priority not. Most my jobs will complete in less than 1s. Appreciate your thoughts about bee-queue?

@behrad
Copy link
Collaborator

behrad commented Feb 8, 2017

have you tested v1 branch @rturk ?
you should align with your requirements if it fits you the bee-queue @rturk

@mir-nawaz-10p
Copy link

mir-nawaz-10p commented Jun 7, 2017

@behrad any updates with the 1.0.0 release?

@Palisand
Copy link

Hello from 2018, how's 1.0.0 looking?

@MetinSeylan
Copy link

hello from future, our cars can flying but kue is still under 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests