Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple unrelocated dependencies + Failed relocation of MariaDB Version-Specific Class #2749

Open
A248 opened this issue Sep 24, 2023 · 0 comments

Comments

@A248
Copy link

A248 commented Sep 24, 2023

What behaviour is observed?

AuthMe shades several dependencies in unrelocated form. Downloading the latest version from the CI, build 2613, and opening the plugin jar yields the following unrelocated packages:

  • com.github.benmanes.caffeine
  • com.sun
  • javax
  • org.apache
  • waffle

Additionally, META-INF/versions/11/org/mariadb/jdbc is not relocated. This is despite that org.mariadb is properly relocated in the main part of the jar, which suggests you may need to update the maven-shade-plugin to a version which solves this problem.

Note that the latest Github Release, 5.6.0-beta2, is missing Caffeine but contains also org.jboss and org.picketbox.

Expected behaviour

The plugin jar contains only classes from the appropriate namespace, fr.xephi. Classes under META-INF/versions should be relocated just like classes in the standard area of the jar.

To Reproduce

  1. Download AuthMe-5.6.0-beta2.jar
  2. Unzip the jar
  3. Observe unrelocated packages
  4. Observe unrelocated META-INF/versions/11

Plugin list

NA

Server Implementation

Standalone server (no proxy)

Database Implementation

SQLite

AuthMe Version

5.6.0-SNAPSHOT-b2613 and 5.6.0-beta2

Error log (if applicable)

NA

Configuration

NA

@A248 A248 added the Type: bug label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant