Successful login message on register

[Twonox]

Is it normal that it have successful login message on register ?

[sgdc3]

I think it's fine @ljacqu

[ljacqu]

@sgdc3 Agreed as this is a border case. Handling this case specifically = ugly code that will have to be maintained.

However, @Twonox @sgdc3, I have a counter proposition—as an enhancement (and an easy pick story 😉) we could distinguish between when a user is force logged in vs. logged in because of his own actions.

• If the player logs in because he used /login, everything stays as before (i.e. if successful -> "Successful login!" message)
• If the player is logged in due to other circumstances (after registration, API use, /authme forcelogin), he receives another message (e.g. "You have been logged in")

-> Same could be done for unregistering. If an admin unregisters a player, the player will get the message "Successfully unregistered!" which is a little weird.

[Twonox]

Mhmm why not.

[sgdc3]

It's fine for me ;)

[Twonox]

@ljacqu I don't appreciate that

and that

The better thing for me it's to sent only one message: only successful register message and session message, without successful login message.
I will appreciate if you undo this (and if you find a solution to maintain easily the code).

[ljacqu]

I will appreciate if you undo this

Do you mean to say that this came when we added the registration type settings? I will check, but the fix will probably only make it in 5.3.

[Maxetto]

I guess this is related, Console login messages are printed more than once.
At register:

29.01 16:24:39 [Server] INFO ProGirl100 registered (IP)
29.01 16:24:39 [Server] INFO ProGirl100 logged in!

At server switch:

29.01 16:47:41 [Server] INFO GalaxyDoritoMC logged in!
29.01 16:47:42 [Server] INFO GalaxyDoritoMC logged in!

Login messages printed twice (or even three times) are due to FastLogin and BungeeAuthMeBridge sending new login thru the API.

[SaitDev]

Also got the message Logged-in due to Session Reconnection, but just got it few times not everytime I loggin.
Using version 5.2 latest release. sessions.enabled is false. No bungge server and no FastLogin.
Did it cause by other plugins that call authme api?

[ljacqu]

@SaitDev this kind of seems like the only possibility; if this problem continues please don't hesitate to create a separate issue about this.