-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Successful login message on register #1052
Comments
I think it's fine @ljacqu |
@sgdc3 Agreed as this is a border case. Handling this case specifically = ugly code that will have to be maintained. However, @Twonox @sgdc3, I have a counter proposition—as an enhancement (and an easy pick story 😉) we could distinguish between when a user is force logged in vs. logged in because of his own actions.
-> Same could be done for unregistering. If an admin unregisters a player, the player will get the message "Successfully unregistered!" which is a little weird. |
Mhmm why not. |
It's fine for me ;) |
@ljacqu I don't appreciate that The better thing for me it's to sent only one message: only successful register message and session message, without successful login message. |
Do you mean to say that this came when we added the registration type settings? I will check, but the fix will probably only make it in 5.3. |
I guess this is related, Console login messages are printed more than once.
At server switch:
Login messages printed twice (or even three times) are due to FastLogin and BungeeAuthMeBridge sending new login thru the API. |
Also got the message |
@SaitDev this kind of seems like the only possibility; if this problem continues please don't hesitate to create a separate issue about this. |
Is it normal that it have successful login message on register ?
The text was updated successfully, but these errors were encountered: