Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth Delay Changes #37

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

sieren
Copy link
Contributor

@sieren sieren commented Jan 31, 2019

Previously Delay Changes coming in from the model would not be smoothed
when updated in the process block, thus resulting in loud clicks.
This would occur not only when changing the delay itself, but also in case of tempo-sync (and with tempo changes propagated through MIDI Sync or Link).

Smoothing the delay time gives it a more analogue feel on changes and gets rid of the
click. (Implementing a fade on changes might require more work, potentially touching the Soundpipe Lib itself)

I'm not sure if this was a conscious decision or an oversight, happy to close this if it was on purpose.

Previously Delay Changes coming in from the model would not be smoothed
when updated in the process block, thus resulting in loud clicks.

Smoothing the delay time gives it a more analogue feel and gets rid of the
click.
@aure aure merged commit dae19e7 into AudioKit:develop Feb 1, 2019
@aure
Copy link
Member

aure commented Feb 1, 2019

I think this is correct, but if its wrong its easy enough to change back. Thanks for your vigilance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants