Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LFO-style routing system to envelopes #23

Closed
SilverWolf32 opened this issue Oct 21, 2018 · 12 comments
Closed

Add LFO-style routing system to envelopes #23

SilverWolf32 opened this issue Oct 21, 2018 · 12 comments

Comments

@SilverWolf32
Copy link

SilverWolf32 commented Oct 21, 2018

We can route LFOs to all sorts of different things. It would be nice if we could do the same for envelopes, for example to make a gradual tremolo effect.

(Also, I accidentally created the issue before I finished the title. Is there some way to remove the title change from the history?)

@SilverWolf32 SilverWolf32 changed the title Ad Add LFO-style routing system to envelopes Oct 21, 2018
@SilverWolf32 SilverWolf32 reopened this Oct 21, 2018
@analogcode
Copy link
Member

Yes. Is that something you want to take the lead on? If so, I'd recommend creating a separate branch. Thanks!

@SilverWolf32
Copy link
Author

I might be able to do that. What language is the app written in? I have experience with ObjC and Swift, but not C++.

@analogcode
Copy link
Member

analogcode commented Oct 21, 2018

C++ is the sound engine. Interface/UI in Swift

@SilverWolf32
Copy link
Author

Cool! I'll take a look, then. I should branch off develop, right?

@analogcode
Copy link
Member

Yes, thanks for asking. We're using Develop to push to App Store. So, a separate branch off of Develop would be preferable. 👍

@SilverWolf32
Copy link
Author

Hm, I'm having trouble getting it to build. I installed the dependencies and replaced the bundle identifier, and I'm still getting some errors.

  • No such module 'ChimpKit'
  • the [CP] Embed Pods Frameworks PhaseScriptExecution command is failing
  • Embedded binary is not signed with the same certificate as the parent app (seems to be the OneSignalNotificationServiceExtension, may resolve after fixing the next one)
  • on the OneSignalNotificationServiceExtension, the linker is failing because of framework not found Pods_OneSignalNotificationServiceExtension.

I looked in Pods/ and ChimpKit is there, it just looks like Xcode isn't seeing it.

Also, under the Inter-App Audio capability it says "your account does not have sufficient permissions to modify containers". What does that mean, and do I have to be an administrator?

@SilverWolf32
Copy link
Author

I didn't know I was supposed to use AudioKitSynthOne .xcworkspace instead of .xcodeproj. Perhaps we should put something about that in the readme. Also, it turns out I had a problem with my build products path. I fixed both issues and it's building just fine now.

@SilverWolf32
Copy link
Author

I went to make space in the ENV panel for the routing settings and discovered that the background is an image.

I found https://github.com/AudioKit/AudioKitGraphics, which looks like it might contain what I need, but I can't open any of the files there since I don't have PaintCode. Does anyone happen to have a .psd, .afphoto, .svg, or similar file of the ENV panel background I could use? Thanks.

@analogcode
Copy link
Member

The Swift part and interface is rather trivial. And, is something I can make right away if you get the hard part working: writing the c/c++ code and modifing the kernel to allow envelope modulation per voice (which may need to be adapted custom for every parameter/destination). I’d recommend you just make some simple UI controls as a PoC to test the real work - writing the C++. If you get that working, circle back. 👍

@SilverWolf32
Copy link
Author

Per voice...you mean independently for every oscillator + the FM system? I have absolutely no experience in signal processing. (: At the moment what I really want is to modify the LFO with an envelope, would that be any easier?

@analogcode
Copy link
Member

Only you can answer that question. I don’t know your skill level. Look at the code and decide.

@SilverWolf32
Copy link
Author

I tried to add some parameters to the synth system in S1DSPKernel.hpp and S1Parameter.h (increasing S1ParameterCount accordingly), but it's now crashing on me. Any idea why that could be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants