Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter name in S1ParameterInfo array #168

Closed
armarpc opened this issue Feb 10, 2021 · 2 comments
Closed

Wrong parameter name in S1ParameterInfo array #168

armarpc opened this issue Feb 10, 2021 · 2 comments

Comments

@armarpc
Copy link

armarpc commented Feb 10, 2021

I just wanted to point out I think there's a small code error in S1DSPKernel.hpp.

On lines 495-497 it says:

{ compressorMasterMakeupGain, 0.5, 2, 4, "master compressor makeup gain", "master compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},
{ compressorReverbInputMakeupGain, 0.5, 1.88, 4, "reverb input compressor makeup gain", "reverb input compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},
{ compressorMasterMakeupGain, 0.5, 1.88, 4, "reverb wet compressor makeup gain", "reverb wet compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},

I think the last line should read:

{ compressorReverbWetMakeupGain, 0.5, 1.88, 4, "reverb wet compressor makeup gain", "reverb wet compressor makeup gain", kAudioUnitParameterUnit_Generic, false, NULL},

I don't think it actually affects anything, but it would still be good to correct it.

@aure
Copy link
Member

aure commented Feb 26, 2021

Make a Pull Request!

@armarpc
Copy link
Author

armarpc commented Mar 1, 2021

I created pull request #169

@aure aure closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants