Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Automatically install linter #26

Merged
merged 1 commit into from
Dec 28, 2015
Merged

Automatically install linter #26

merged 1 commit into from
Dec 28, 2015

Conversation

Arcanemagus
Copy link
Member

Automatically install the linter package if it isn't already installed.

Fixes #6.

Review on Reviewable

Automatically install the linter package if it isn't already installed.
@Arcanemagus
Copy link
Member Author

@wooorm since I love your beautiful documentation, can you make sure what I did there is sufficient?

@Arcanemagus
Copy link
Member Author

Did a bit more looking into it, leaving out the @return should be fine since the function returns undefined. Merging.

Arcanemagus added a commit that referenced this pull request Dec 28, 2015
@Arcanemagus Arcanemagus merged commit 5882dba into master Dec 28, 2015
@Arcanemagus Arcanemagus deleted the install-linter branch December 28, 2015 22:57
@wooorm
Copy link
Contributor

wooorm commented Dec 29, 2015

Great! I'm personally in favour of the newlines after block-comments, but can adjust to the project style guide :)

@Arcanemagus
Copy link
Member Author

Actually there isn't one, just all but the two I removed had no line break so I made things consistent 😉

(Personally I prefer none anyway, but it's not a big deal either way)

@Arcanemagus
Copy link
Member Author

@wooorm looks like a release hasn't been pushed out in a while, do you want to push one up or should I?

@wooorm
Copy link
Contributor

wooorm commented Dec 29, 2015

AWFK, could you?

@Arcanemagus
Copy link
Member Author

Sure

@Arcanemagus
Copy link
Member Author

v1.3.0 released 😉.

@wooorm
Copy link
Contributor

wooorm commented Dec 29, 2015

👍

@Arcanemagus
Copy link
Member Author

Wow, I completely failed to actually list linter as a dependency here, causing #112. 😞

Arcanemagus added a commit that referenced this pull request Sep 21, 2016
The second part of the changes introduced in #26.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants