Lint markdown files with mdast #16
Conversation
SpainTrain
commented
Dec 10, 2015
- Dogfood the linter by linting its own markdown files
- Add linting to CI
bbdaa12
to
52843a0
Compare
| @@ -11,6 +11,8 @@ dependencies: | |||
| - atom -v | |||
| - apm -v | |||
| - apm install | |||
| # test: | |||
| test: | |||
| pre: | |||
There was a problem hiding this comment.
I would rather this was changed to:
test:
override:
- npm run lint
- npm testSo that we are explicitly stating what we want tested instead of relying on Circle's inference behavior, but currently at least it makes no difference so it could go either way.
There was a problem hiding this comment.
We've discussed a similar issue before. IMO it doesn't make sense to override with the default, it's just redundant. Also, I explicitly do want to lint before testing. Until there are specs and we truly do want to override default behavior with the atom plugin testing script, I feel like this is a sensible config...
There was a problem hiding this comment.
Merge away then, just wanted to make sure it was thought about 😉.
52843a0
to
08186c4
Compare
| @@ -4,6 +4,7 @@ | |||
| "version": "1.2.3", | |||
| "description": "Lint markdown on the fly, using mdast-lint", | |||
| "scripts": { | |||
| "lint": "mdast -u mdast-lint README.md LICENSE.md", | |||
There was a problem hiding this comment.
Would have preferred wildcard, but changelog.md appears to be generated, so linting it would be a bit of a pain.
Sure, but I do not know who. @leipert ? |
|
Probably, but you could just set the holder to the AtomLinter organization. Since both you and @leipert are members you would share the copyright. But you'd also be sharing it with everyone else in the organization. |
* Dogfood the linter by linting its own markdown files * Add linting to CI
08186c4
to
eb92223
Compare
|
This LGTM other than the |
Lint markdown files with mdast