New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard-coded value(s) in test case(s) #695

Open

Rita-C opened this issue Aug 1, 2019 · 0 comments

Contributor

Rita-C commented Aug 1, 2019

Found an image url is hard coded in a test case (AccessControlFilterSpec.groovy).

This is not good practice, we should not keep an image around for a unit test though, remove the test or mock the http out of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment