Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor File/Disk Access for Private and Staged Images #315

Open
pwscsiro opened this issue Mar 16, 2016 · 1 comment
Open

Refactor File/Disk Access for Private and Staged Images #315

pwscsiro opened this issue Mar 16, 2016 · 1 comment

Comments

@pwscsiro
Copy link
Contributor

It might be worth considering refactoring the way this is done with a view to removing duplication by centralising the read and writes in one place, maybe in a Service supported by some object oriented components. The latter would help reduce reliance on static method calls and magic hard-coded strings. The various file paths might be good as properties on a bean. The benefits of this would be easier to read, easier to maintain, easier to change, easier to extend. The features that would be impacted include uploading images, displaying images, deleting images, creating thumbnails, creating tiles and publishing (moving) images to the central repository - Biocache.

@ben3000
Copy link

ben3000 commented Aug 2, 2016

See also #322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants