#1422, #1433 #766
Merged
#1422, #1433 #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 26, 2022 22:26
…roject id when generating download Increased params.max to 20000
temi
requested changes
Aug 5, 2022
grails-app/services/au/org/ala/ecodata/ElasticSearchService.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/au/org/ala/ecodata/reporting/CSProjectXlsExporter.groovy
Show resolved
Hide resolved
grails-app/controllers/au/org/ala/ecodata/SearchController.groovy
Outdated
Show resolved
Hide resolved
… if a user has a specified roles in a project
addresses activity slowness
added a test case
yasima-csiro
approved these changes
Aug 9, 2022
chrisala
reviewed
Aug 9, 2022
| def isUserMemberOfProject() { | ||
| String userId = params.userId | ||
| String projectId = params.projectId | ||
| String roles = params.roles ?: "admin,caseManager,moderator,editor,projectParticipant" |
There was a problem hiding this comment.
Rather than hard-coding the strings here, it would be better to use the AccessLevel enum to derive them. It would also be more http idomatic to use params.getList() and send it from biocollect in the form &roles=admin&roles=moderator etc.
There was a problem hiding this comment.
WIthout understanding how it's used in biocollect, an alternative would be to use "findUserPermission(userId, projectId)" and do the role processing on the client side.
There was a problem hiding this comment.
Changed.
Doing on client side was causing BioCollect to be really slow on projects with large number of members. Moved BioCollect functionality to ecodata to address this issue.
src/main/groovy/au/org/ala/ecodata/reporting/CSProjectXlsExporter.groovy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.